Re: Missing include <openssl/x509.h> in be-secure-openssl.c?

From: 近藤雄太 <kondo(at)sraoss(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: buildfarm(at)sraoss(dot)co(dot)jp, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Missing include <openssl/x509.h> in be-secure-openssl.c?
Date: 2021-11-09 08:45:27
Message-ID: 20211109174527.64095ae7f521b6fcc4b72c64@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 08 Nov 2021 12:05:24 -0500
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> I wrote:
> > The rough idea I have is that prior to 8162464a2, we sucked in
> > that #define during postgres.h and then OpenSSL's headers were
> > able to undo it. After 8162464a2, we don't read <wincrypt.h>
> > during postgres.h, but some *other* header that be-secure-openssl.c
> > is including after the OpenSSL headers is pulling it in, so that
> > by the time we get to the body of the file the unwanted #define
> > is active.
>
> This indeed seems to explain the compile failures, as hamerkop is
> now getting through the "make" stage. However, it's now failing
> in the plpython tests [1], apparently because Python itself doesn't
> like the locale environment:
>
> Fatal Python error: init_sys_streams: can't initialize sys standard streams
> LookupError: unknown encoding: cp20127
>
> Did something change on that machine in the last day or so? Because
> plpython seems to have been working fine in the back branches.
>
> regards, tom lane
>
> [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hamerkop&dt=2021-11-08%2010%3A08%3A22

Sorry. The error was caused by using "chcp 20127" in the build script when
we were trying to make the compiler error messages in English.

We removed "chcp 20127" and run the build script. It seems to be building
fine. Please check it.

------------------------------------------
Kondo Yuta <kondo(at)sraoss(dot)co(dot)jp>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wenjing 2021-11-09 08:51:22 Re: [Proposal] Global temporary tables
Previous Message Kyotaro Horiguchi 2021-11-09 08:05:49 Re: standby recovery fails (tablespace related) (tentative patch and discussion)