Re: pgsql: pgcrypto: Remove non-OpenSSL support

Hi,

On 2021-11-06 19:07:29 -0700, Andres Freund wrote:
> On 2021-11-07 10:38:07 +0900, Michael Paquier wrote:
> > On Sat, Nov 06, 2021 at 03:34:20PM -0700, Andres Freund wrote:
> > > It was sufficient. The tests are still running, but the pgcrypto test just
> > > passed (see contribcheck_test):
> > > https://cirrus-ci.com/task/6128369478664192
> > > vs previous run before rebasing:
> > > https://cirrus-ci.com/task/5856750176829440
> > >
> > > This is the meson branch, but testing the src/tools/msvc style build.
> >
> > The build is fixed, but not the buildfarm:
> > 2021-11-06 15:49:48.623 EDT [21704:4] pg_regress/init LOG: statement:
> > CREATE EXTENSION pgcrypto;
> > 2021-11-06 15:49:48.637 EDT [21704:5] pg_regress/init ERROR: could
> > not access file "$libdir/pgcrypto": No such file or directory
> > 2021-11-06 15:49:48.637 EDT [21704:6] pg_regress/init STATEMENT:
> > CREATE EXTENSION pgcrypto;
> >
> > It looks like this missed an installation path. This should be
> > reproducible in my own environment, but I don't have the room to look
> > at it seriously today.
>
> Hm? That's what I was seeing before, and what got fixed by
> 3c2c391dc9f82fae181508ebcc2f7621ffefd024

The log excerpt appears to be from bowerbird [1], and predates that commit. I
didn't see any windows buildfarm run that completed since the above commit.

Greetings,

Andres Freund

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-11-06%2019%3A13%3A40