Re: pgsql: pgcrypto: Remove non-OpenSSL support

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pgcrypto: Remove non-OpenSSL support
Date: 2021-11-06 22:04:10
Message-ID: 20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2021-11-05 13:09:55 +0000, Peter Eisentraut wrote:
> pgcrypto: Remove non-OpenSSL support
>
> pgcrypto had internal implementations of some encryption algorithms,
> as an alternative to calling out to OpenSSL. These were rarely used,
> since most production installations are built with OpenSSL. Moreover,
> maintaining parallel code paths makes the code more complex and
> difficult to maintain.
>
> This patch removes these internal implementations. Now, pgcrypto is
> only built if OpenSSL support is configured.

This appears to have broken msvc pgcrypto being tested with msvc. I think
that's because pgcrypto is still listed in the "base" @contrib_excludes and
thus just isn't getting built anymore, now that the special-case build rule is
gone?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-11-06 22:07:09 Re: pgsql: pgcrypto: Remove non-OpenSSL support
Previous Message Tom Lane 2021-11-06 22:02:35 pgsql: Blind attempt to fix MSVC pgcrypto build.