| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: make tuplestore helper function |
| Date: | 2021-11-02 20:23:53 |
| Message-ID: | 20211102202353.GG17618@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Several places have a conditional value for the first argument (randomAccess),
but your patch changes the behavior to a constant "true". I didn't review the
patch beyond that.
> @@ -740,18 +724,14 @@ pg_prepared_statement(PG_FUNCTION_ARGS)
> - tupstore =
> - tuplestore_begin_heap(rsinfo->allowedModes & SFRM_Materialize_Random,
> - false, work_mem);
> @@ -2701,42 +2701,13 @@ pg_hba_file_rules(PG_FUNCTION_ARGS)
> - tuple_store =
> - tuplestore_begin_heap(rsi->allowedModes & SFRM_Materialize_Random,
> - false, work_mem);
> @@ -4799,31 +4797,8 @@ pg_timezone_names(PG_FUNCTION_ARGS)
> - randomAccess = (rsinfo->allowedModes & SFRM_Materialize_Random) != 0;
> - tupstore = tuplestore_begin_heap(randomAccess, false, work_mem);
> @@ -575,38 +575,12 @@ pg_ls_dir_1arg(PG_FUNCTION_ARGS)
> - randomAccess = (rsinfo->allowedModes & SFRM_Materialize_Random) != 0;
> - tupstore = tuplestore_begin_heap(randomAccess, false, work_mem);
> @@ -1170,17 +1154,12 @@ pg_cursor(PG_FUNCTION_ARGS)
> - tupstore =
> - tuplestore_begin_heap(rsinfo->allowedModes & SFRM_Materialize_Random,
> - false, work_mem);
> +++ b/src/backend/utils/fmgr/funcapi.c
> + tupstore = tuplestore_begin_heap(true, false, maxKBytes);
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-11-02 20:47:06 | Re: should we enable log_checkpoints out of the box? |
| Previous Message | Justin Pryzby | 2021-11-02 20:06:52 | Re: should we enable log_checkpoints out of the box? |