| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | bossartn(at)amazon(dot)com |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, michael(at)paquier(dot)xyz, andres(at)anarazel(dot)de, sulamul(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: inefficient loop in StandbyReleaseLockList() |
| Date: | 2021-11-02 00:58:16 |
| Message-ID: | 20211102.095816.955935512275303285.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Mon, 1 Nov 2021 17:02:49 +0000, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote in
> On 11/1/21, 9:58 AM, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > "Bossart, Nathan" <bossartn(at)amazon(dot)com> writes:
> >> Should there be a list_free(trgmNFA->queue) at the end of
> >> transformGraph()?
> >
> > There could be, but that's visibly invoked only once per
> > createTrgmNFAInternal call, so I didn't think it was worthwhile
> > to do so (unlike the case for processState). If we were concerned
> > about leakage in that function, the hash table would be a far
> > bigger issue.
>
> Ah, I see it now. The patch looks good to me, then.
+1
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-11-02 01:13:09 | Re: Added schema level support for publication. |
| Previous Message | Kyotaro Horiguchi | 2021-11-02 00:57:48 | Re: inefficient loop in StandbyReleaseLockList() |