Re: pgsql: Refactor the sslfiles Makefile target for ease of use

Hi,

On 2021-10-19 18:17:34 +0000, Daniel Gustafsson wrote:
> Refactor the sslfiles Makefile target for ease of use
>
> The Makefile handling of certificate and keypairs used for TLS testing
> had become quite difficult to work with. Adding a new cert without the
> need to regenerate everything was too complicated. This patch refactors
> the sslfiles make target such that adding a new certificate requires
> only adding a .config file, adding it to the top of the Makefile, and
> running make sslfiles.

This fails during 'make clean' in a vpath build, because sslfiles.mk cannot be
found. Probably just needs

diff --git i/src/test/ssl/Makefile w/src/test/ssl/Makefile
index 3592c0d184f..cb24e31c6e2 100644
--- i/src/test/ssl/Makefile
+++ w/src/test/ssl/Makefile
@@ -19,11 +19,11 @@ export with_ssl
# with settings in Makefile.global.
.PHONY: sslfiles sslfiles-clean
sslfiles sslfiles-clean:
- $(MAKE) -f sslfiles.mk $@
+ $(MAKE) -f $(srcdir)/sslfiles.mk $@

clean distclean maintainer-clean:
rm -rf tmp_check
- $(MAKE) -f sslfiles.mk $@
+ $(MAKE) -f $(srcdir)/sslfiles.mk $@

# Doesn't depend on sslfiles because we don't rebuild them by default
check:

Greetings,

Andres Freund