Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pgsql(at)j-davis(dot)com
Cc: bossartn(at)amazon(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().
Date: 2021-10-25 04:13:43
Message-ID: 20211025.131343.1014922659972760300.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Sun, 24 Oct 2021 20:31:37 -0700, Jeff Davis <pgsql(at)j-davis(dot)com> wrote in
> On Mon, 2021-10-25 at 11:53 +0900, Kyotaro Horiguchi wrote:
> > In other words, I don't think pg_signal_backends is not meant to
> > control "log something on another session" or "rotate log file".
> > It's
> > danger that if we allow somewone to rotate log files, that means to
> > allow same user to terminate another session.
>
> The current patch doesn't allow members of pg_signal_backend to rotate
> the log file.

Ah, sorry, I might have confused with some other discussion.

> Do you think pg_signal_backend is the wrong group to allow usage of
> pg_log_backend_memory_contexts()? Alternatively, it could simply not

Yes. I think it would be danger that who is allowed to dump memory
context into log files by granting pg_signal_backend also can
terminate other backends.

> pg_log_backend_memory_contexts()? Alternatively, it could simply not
> GRANT anything, and leave that up to the administrator to choose who
> can use it.

*I* prefer that. I'm not sure I'm the only one to think so, though..

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-10-25 04:27:52 Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().
Previous Message Jeff Davis 2021-10-25 03:31:37 Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats().