| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com> |
| Cc: | masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: Improve logging when using Huge Pages |
| Date: | 2021-10-22 02:38:15 |
| Message-ID: | 20211022023815.GI741@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
+ ereport(LOG, (errmsg("Anonymous shared memory was allocated %s huge pages.", with_hugepages ? "with" : "without")));
You shouldn't break a sentence into pieces like this, since it breaks
translation. You don't want an untranslated "without" to appear in the middle
of the translated message.
There are cases where a component *shouldn't* be translated, like this one:
where "numeric" should not be translated.
src/backend/utils/adt/numeric.c: errmsg("invalid input syntax for type %s: \"%s\"",
src/backend/utils/adt/numeric.c- "numeric", str)));
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-10-22 02:43:08 | Re: Drop replslot after pgstat_shutdown cause assert coredump |
| Previous Message | Japin Li | 2021-10-22 02:37:28 | Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber |