Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

Hi,

On 2021-10-18 11:39:08 -0400, Andrew Dunstan wrote:
> On 10/18/21 10:23 AM, Alvaro Herrera wrote:
> > On 2021-Oct-17, Andrew Dunstan wrote:
> >
> >> +sub find_built_program
> >> +{
> >> + my $program = shift;
> >> + my $path;
> >> +
> >> + if (defined $ENV{MSBUILDDIR})
> >> + {
> >> + # vcregress.pl sets MSBUILDDIR which is the root of all the build dirs
> >> + my $wanted = sub { $_ eq "$program.exe" && $path = $File::Find::name;};
> >> + File::Find::find($wanted,$ENV{MSBUILDDIR});
> >> + }
> > Hmm, it seems weird to have to use File::Find when we already know where
> > the program is, right? I mean, per your previous patch, we know that
> > the program is in $MSBUILDDIR/libpq_pipeline/libpq_pipeline.exe, so why
> > don't we make this one be
> >
> > if (defined $ENV{MSBUILDDIR})
> > {
> > return $ENV{MSBUILDDIR} . "$program/$program.exe";
> > }
>
>
> Could do, but say the module had two programs? Mostly we don't do that
> but Release/pg_isolation_regress has two executables, so it's more than
> just theoretically possible.

ISTM that we should just make the "test invocation framework" responsible to
put the relevant directory onto PATH? I.e. Makefile.global should add the
build directory of the test to PATH, and vcregress.pl should put the relevant
$configuration/$project/ directory there?

Greetings,

Andres Freund