| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Thomas Munro <tmunro(at)postgresql(dot)org> |
| Subject: | Re: ldap/t/001_auth.pl fails with openldap 2.5 |
| Date: | 2021-10-19 18:20:16 |
| Message-ID: | 20211019182016.aa6kjrenfk4jkxlg@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-10-10 00:45:41 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Although I'm mildly tempted to rewrap the parameters, it's kinda odd how the
> > trailing parameter on one line, has its value on the next line.
>
> I'm betting that perltidy did that. If you want to fix it so it
> stays fixed, maybe reordering the parameters could help.
You were right on that front. Since perltidy insisted on reflowing due to the
reduction in number of parameters anyway, I did end up switching things around
so that the parameters look a bit more reasonable.
> > So, does anybody see a reason not to go for the trivial
> > [ patch ]
>
> I'd be happy to rely on the buildfarm's opinion here.
Let's see what it says...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-10-19 18:21:31 | Re: [PATCH] test/ssl: rework the sslfiles Makefile target |
| Previous Message | Alvaro Herrera | 2021-10-19 18:07:17 | Re: Parallel vacuum workers prevent the oldest xmin from advancing |