| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Euler Taveira <euler(at)eulerto(dot)com>, "nikolai(dot)berkoff" <nikolai(dot)berkoff(at)pm(dot)me>, "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ALTER TABLE ... SET DATA TYPE removes statistics |
| Date: | 2021-10-19 15:16:44 |
| Message-ID: | 202110191516.eufiqzha2etw@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On 2021-Oct-19, Michael Paquier wrote:
> On Mon, Oct 18, 2021 at 05:15:59PM -0300, Euler Taveira wrote:
> > I agree that it might surprise an user and it would be good to document it.
> > However, it does not belong to the description. I would add it to the Notes
> > section at the end of the ALTER TABLE page.
>
> No objections to the suggested addition and the location of the
> addition (paragraph of SET DATA TYPE rather than "Notes"), but I think
> that the phrasing could be better:
> "The column's statistics are removed, hence a follow-up ANALYZE is
> suited to update the statistics to the new column type."
Dunno, putting it in the middle of the existing paragraph looks odd to
me. I would put it in a separate one instead, as in the attached.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| datatype.patch | text/x-diff | 646 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pascal CROZET | 2021-10-19 15:41:50 | migrate from PG 9.5 to PG 12 or more |
| Previous Message | PG Doc comments form | 2021-10-19 08:59:08 | max_sync_workers_per_subscription |