From: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> |
---|---|
To: | vignesh C <vignesh21(at)gmail(dot)com> |
Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Identify missing publications from publisher while create/alter subscription. |
Date: | 2021-09-28 02:19:44 |
Message-ID: | 20210928021944.GA18070@ahch-to |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 26, 2021 at 07:49:49PM +0530, vignesh C wrote:
> On Thu, Jul 15, 2021 at 5:57 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > On Tue, Jul 6, 2021 at 8:09 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > >
> > > On Wed, Jun 30, 2021 at 8:23 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > >
> > > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > > >
> > > > > On Fri, May 7, 2021 at 6:44 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > > > >
> > > > > > Thanks for the comments, the attached patch has the fix for the same.
> > > > >
>
> The patch was not applying on the head, attached patch which is rebased on HEAD.
>
Hi,
I'm testing this patch now. It doesn't apply cleanly but is the
documentation part, so while a rebase would be good it doesn't avoid me
to test.
A couple of questions:
+check_publications(WalReceiverConn *wrconn, List *publications,
+ bool validate_publication)
[...]
+connect_and_check_pubs(Subscription *sub, List *publications,
+ bool validate_publication)
I wonder why validate_publication is passed as an argument just to
return if it's false, why not just test it before calling those
functions? Maybe is just a matter of style.
+get_publications_str(List *publications, StringInfo dest, bool quote_literal)
what's the purpose of the quote_literal argument?
--
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-09-28 02:20:12 | Re: Fixing WAL instability in various TAP tests |
Previous Message | Michael Paquier | 2021-09-28 02:15:39 | Re: typos (and more) |