Re: prevent immature WAL streaming

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "mengjuan(dot)cmj(at)alibaba-inc(dot)com" <mengjuan(dot)cmj(at)alibaba-inc(dot)com>, "Jakub(dot)Wartak(at)tomtom(dot)com" <Jakub(dot)Wartak(at)tomtom(dot)com>, Ryo Matsumura <matsumura(dot)ryo(at)fujitsu(dot)com>
Subject: Re: prevent immature WAL streaming
Date: 2021-09-25 00:48:48
Message-ID: 202109250048.kbyaczlqdvwy@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Sep-23, Alvaro Herrera wrote:

> On 2021-Sep-23, Alvaro Herrera wrote:
>
> > However, I notice now that the pg_rewind tests reproducibly fail in
> > branch 14 for reasons I haven't yet understood. It's strange that no
> > other branch fails, even when run quite a few times.
>
> Turns out that this is a real bug (setting EndOfLog seems insufficient).
> I'm looking into it.

I had misdiagnosed it; the real problem is that this was taking action
in standby mode and breaking things after promotion. I took quite a
detour ...

Here's the set for all branches, which I think are really final, in case
somebody wants to play and reproduce their respective problem scenarios.
Nathan already confirmed that his reproducer no longer shows a problem,
and this version shouldn't affect that.

--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"El Maquinismo fue proscrito so pena de cosquilleo hasta la muerte"
(Ijon Tichy en Viajes, Stanislaw Lem)

Attachment Content-Type Size
0001-Fix-WAL-replay-in-presence-of-an-incomplete-record.patch text/x-diff 26.4 KB
v10-0001-Fix-WAL-replay-in-presence-of-an-incomplete-reco.patch text/x-diff 22.1 KB
v11-0001-Fix-WAL-replay-in-presence-of-an-incomplete-reco.patch text/x-diff 21.9 KB
v12-0001-Fix-WAL-replay-in-presence-of-an-incomplete-reco.patch text/x-diff 21.9 KB
v13-0001-Fix-WAL-replay-in-presence-of-an-incomplete-reco.patch text/x-diff 21.7 KB
v14-0001-Fix-WAL-replay-in-presence-of-an-incomplete-reco.patch text/x-diff 26.5 KB
v96-0001-Fix-WAL-replay-in-presence-of-an-incomplete-reco.patch text/x-diff 22.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2021-09-25 01:17:21 Re: decoupling table and index vacuum
Previous Message Mark Dilger 2021-09-25 00:33:13 Fixing WAL instability in various TAP tests