| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "mengjuan(dot)cmj(at)alibaba-inc(dot)com" <mengjuan(dot)cmj(at)alibaba-inc(dot)com>, "Jakub(dot)Wartak(at)tomtom(dot)com" <Jakub(dot)Wartak(at)tomtom(dot)com> |
| Subject: | Re: prevent immature WAL streaming |
| Date: | 2021-09-17 21:22:00 |
| Message-ID: | 202109172122.y3kcil5qhfpy@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Sep-17, Bossart, Nathan wrote:
> > That was the first implementation, a few versions of the patch ago. An
> > added benefit of a separate WAL record is that you can carry additional
> > data for validation, such as -- as suggested by Andres -- the CRC of the
> > partial data contained in the message that we're skipping. I didn't
> > implement that, but it should be trivial to add it.
>
> I see. IMO feels a bit counterintuitive to validate a partial record
> that you are ignoring anyway, but I suppose it's still valuable to
> know when the WAL is badly broken. It's not expensive, and it doesn't
> add a ton of complexity, either.
Yeah, we don't have any WAL record history validation other than the
verifying the LSN of the previous record; I suppose in this particular
case you could argue that we shouldn't bother with any validation
either. But it seems safer to do it. It doesn't hurt anything anyway.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2021-09-17 21:35:58 | Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert |
| Previous Message | Bossart, Nathan | 2021-09-17 21:15:27 | Re: prevent immature WAL streaming |