| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Don't clean up LLVM state when exiting in a bad way |
| Date: | 2021-09-14 01:32:55 |
| Message-ID: | 20210914013255.wgt6a5flb6h253ci@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-09-07 14:44:39 -0500, Justin Pryzby wrote:
> On Tue, Sep 07, 2021 at 12:27:27PM -0700, Andres Freund wrote:
> > I think this is a tad too strong. We should continue to clean up on exit as
> > long as the error didn't happen while we're already inside llvm
> > code. Otherwise we loose some ability to find leaks. How about checking in the
> > error path whether fatal_new_handler_depth is > 0, and skipping cleanup in
> > that case? Because that's precisely when it should be unsafe to reenter
> > LLVM.
The more important reason is actually profiling information that needs to be
written out.
I've now pushed a fix to all relevant branches. Thanks all!
Regards,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-09-14 02:26:57 | RE: Skipping logical replication transactions on subscriber side |
| Previous Message | Michael Paquier | 2021-09-14 01:23:48 | Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c |