| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | masao(dot)fujii(at)oss(dot)nttdata(dot)com, andres(at)anarazel(dot)de, pgsql-hackers(at)lists(dot)postgresql(dot)org, bossartn(at)amazon(dot)com, mengjuan(dot)cmj(at)alibaba-inc(dot)com, Jakub(dot)Wartak(at)tomtom(dot)com |
| Subject: | Re: prevent immature WAL streaming |
| Date: | 2021-09-04 00:01:50 |
| Message-ID: | 202109040001.zky3wgv2qeqg@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I thought that the way to have debug output for this new WAL code is to
use WAL_DEBUG; that way it won't bother anyone and we can remove them
later if necessary.
Also, I realized that we should cause any error in the path that
assembles a record from contrecords is to set a flag that we can test
after the standard "err:" label; no need to create a new label.
I also wrote a lot more comments to try and explain what is going on and
why.
I'm still unsure about the two-flags reporting in xlogreader, so I put
that in a separate commit. Opinions on that one?
The last commit is something I noticed in pg_rewind ...
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"No hay ausente sin culpa ni presente sin disculpa" (Prov. francés)
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Revert-Avoid-creating-archive-status-.ready-files.patch | text/x-diff | 17.2 KB |
| v3-0002-Implement-FIRST_IS_ABORTED_CONTRECORD.patch | text/x-diff | 8.8 KB |
| v3-0003-crosscheck-that-FIRST_IS_CONTRECORD-is-not-togeth.patch | text/x-diff | 1.5 KB |
| v3-0004-debugging-changes.patch | text/x-diff | 1.7 KB |
| v3-0005-upgrade-assert-to-if-in-pg_rewind.patch | text/x-diff | 981 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-09-04 00:03:45 | Re: prevent immature WAL streaming |
| Previous Message | Jacob Champion | 2021-09-03 23:54:01 | Re: [PATCH] support tab-completion for single quote input with equal sign |