| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Spelling change in LLVM 14 API |
| Date: | 2021-08-29 15:40:31 |
| Message-ID: | 202108291540.rk7pbumviz3z@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Aug-22, Tom Lane wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > After [1], seawasp blew up[2]. I tested the following fix on LLVM 13
> > and 14 (main branch ~2 days ago). Better ideas welcome.
>
> > - if (F.getAttributes().hasFnAttribute(llvm::Attribute::NoInline))
> > +#if LLVM_VERSION_MAJOR < 14
> > +#define hasFnAttr hasFnAttribute
> > +#endif
> > +
> > + if (F.getAttributes().hasFnAttr(llvm::Attribute::NoInline))
>
> Seems like either we should push back on pointless renaming, or else
> that we're not really supposed to be accessing this non-stable API.
> I have no idea which of those situations applies ... but if the LLVM
> guys are randomly renaming methods that *are* supposed to be
> user-visible, they need re-education.
Did anything happen? Seawasp is still red ...
--
Álvaro Herrera
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2021-08-29 15:46:41 | Re: AIX: Symbols are missing in libpq.a |
| Previous Message | Tom Lane | 2021-08-29 13:51:58 | Re: Can we get rid of repeated queries from pg_dump? |