Re: Tab completion for "create unlogged" a bit too lax?

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tab completion for "create unlogged" a bit too lax?
Date: 2021-08-24 11:52:14
Message-ID: 20210824115214.GM10479@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 24, 2021 at 11:32:14AM +0000, Daniel Westermann (DWE) wrote:
> tab completion for "create unlogged" gives this:
>
> postgres=# create unlogged
> MATERIALIZED VIEW TABLE
>
> Given that a materialized table can not be unlogged:
>
> postgres=# create unlogged materialized view mv1 as select 1;
> ERROR: materialized views cannot be unlogged
>
> Should this really show up there?

It seems to be deliberate:

commit 3223b25ff737c2bf4a642c0deb7be2b30bfecc6e
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Date: Mon May 6 11:57:05 2013 -0400

Disallow unlogged materialized views.
...
I left the grammar and tab-completion support for CREATE UNLOGGED
MATERIALIZED VIEW in place, since it's harmless and allows delivering a
more specific error message about the unsupported feature.

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2021-08-24 11:59:55 Re: [GSoC 2021 project summary] PL/Julia
Previous Message Daniel Westermann (DWE) 2021-08-24 11:32:14 Tab completion for "create unlogged" a bit too lax?