Re: pgsql: process startup: Centralize pgwin32_signal_initialize() calls.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: process startup: Centralize pgwin32_signal_initialize() calls.
Date: 2021-08-05 23:13:42
Message-ID: 20210805231342.k37dn6462c7ab7js@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2021-08-05 14:41:09 -0700, Andres Freund wrote:
> On 2021-08-05 19:36:30 +0000, Andres Freund wrote:
> > process startup: Centralize pgwin32_signal_initialize() calls.
> >
> > For one, the existing location lead to somewhat awkward code in main(). For
> > another, the new location is easier to understand anyway.
> >
> > Author: Andres Freund <andres(at)anarazel(dot)de>
> > Reviewed-By: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
> > Reviewed-By: Robert Haas <robertmhaas(at)gmail(dot)com>
> > Discussion: https://postgr.es/m/20210802164124.ufo5buo4apl6yuvs@alap3.anarazel.de
>
> Looking at the windows failures...

A bit embarassing: https://www.postgresql.org/message-id/E1mBlyy-00015X-Rt%40gemulon.postgresql.org

Once I went through the effort of getting my windows vm + msvc build running
again it was fairly obvious...

Perhaps we should get windows postgres work on wine, I don't think it'd take
that much.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-08-06 00:23:58 Re: pgsql: Enable TAP tests of pg_receivewal for ZLIB on Windows, take thre
Previous Message Tom Lane 2021-08-05 23:10:22 pgsql: Doc: remove commit 2945a488a from v14 release notes.