| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, jeff(dot)janes(at)gmail(dot)com, mk(at)071(dot)ovh, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size |
| Date: | 2021-07-29 21:19:24 |
| Message-ID: | 202107292119.l3ts46r3f2vc@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2021-Jul-29, Kyotaro Horiguchi wrote:
> At Thu, 29 Jul 2021 16:20:38 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> > So it seems to me we need to explicitly prevent unexpected checkpoints
> > from happening maybe by enlarging max_wal_size temporily.
>
> I ended up with the attached. It causes a checkpoint reliably exactly
> at the aimed timing without.
Thanks for looking into it. The explanation makes sense, so I pushed
your patch and also fixed one outdated comment I noticed while reading
the related code. I hope this commit will solve the problem ... it is
quite low probability, so we'll have to wait at least two weeks to make
any conclusion.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-07-29 21:41:33 | Re: BUG #17116: Assert failed in SerialSetActiveSerXmin() on commit of parallelized serializable transaction |
| Previous Message | Andrey Borodin | 2021-07-29 14:21:44 | Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data |