Re: pg_upgrade does not upgrade pg_stat_statements properly

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Dave Cramer <davecramer(at)gmail(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Date: 2021-07-29 15:24:49
Message-ID: 20210729152449.GI9600@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 29, 2021 at 11:17:52AM -0400, Dave Cramer wrote:
> On Thu, 29 Jul 2021 at 11:10, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> OK, I think we should be more clear as to what is happening.  Saying they will
> be recreated is misleading.
> The extension definitions are being copied from the old server to the new
> server.

I think my wording is says exactly that:

Do not load the schema definitions, e.g., <command>CREATE EXTENSION
pgcrypto</command>, because these will be recreated from the old
cluster.

> I also think we should have stronger wording in the "The extensions may be
> upgraded ..." statement. 
> I'd suggest "Any new versions of extensions should be upgraded using...."

I can't really comment on that since I see little mention of upgrading
extensions in our docs.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2021-07-29 15:28:12 Re: pg_upgrade does not upgrade pg_stat_statements properly
Previous Message wenjing zeng 2021-07-29 15:19:23 Re: [Proposal] Global temporary tables