Re: Configure with thread sanitizer fails the thread test

On Fri, Jul 23, 2021 at 01:42:41PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > ... that said, I wonder why would we do this in the thread_test program
> > rather than in configure itself. Wouldn't it make more sense for the
> > configure test to be skipped altogether (marking the result as
> > thread-safe) when running under thread sanitizer, if there's a way to
> > detect that?
>
> TBH, I wonder why we don't just nuke thread_test.c altogether.
> Is it still useful in 2021? Machines that still need
> --disable-thread-safety can doubtless be counted without running
> out of fingers, and I think their owners can be expected to know
> that they need that.

I think it is fine to remove it. It was really designed to just try a
lot of flags to see what the compiler required, but things have become
much more stable since it was written.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.