| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org, Jacob Champion <pchampion(at)vmware(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: alter table set TABLE ACCESS METHOD |
| Date: | 2021-07-22 09:41:54 |
| Message-ID: | 20210722094154.GD19620@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 22, 2021 at 10:37:12AM +0530, vignesh C wrote:
> On Fri, Jul 16, 2021 at 9:19 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> >
> > rebased.
> >
> > Also, there were two redundant checks for multiple SET ACCESS METHOD commands.
> > But one of them wasn't hit if the ALTER was setting the current AM due to the
> > no-op test.
> >
> > I think it's better to fail in every case, and not just sometimes (especially
> > if we were to use ERRCODE_SYNTAX_ERROR).
> >
> > I included my 2ndary patch allowing to set the AM of partitioned table, same as
> > for a tablespace.
>
> One of the tests is failing, please post an updated patch for this:
> create_am.out 2021-07-22 10:34:56.234654166 +0530
It looks like one hunk was missing/uncommitted from the 0002 patch..
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-ALTER-TABLE-.-SET-ACCESS-METHOD.patch | text/x-diff | 18.7 KB |
| 0002-Allow-specifying-access-method-of-partitioned-tables.patch | text/x-diff | 12.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Luzanov | 2021-07-22 10:14:19 | Re: postgresql.conf.sample missing units |
| Previous Message | wenjing | 2021-07-22 09:40:49 | Re: [Proposal] Global temporary tables |