Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: jeff(dot)janes(at)gmail(dot)com, mk(at)071(dot)ovh, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size
Date: 2021-07-16 18:09:33
Message-ID: 202107161809.zclasccpfcg3@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

I was running tests for another patch, and this one failed once:

Testing REL_14_BETA2-168-g1cb94c3c4c started: vie jul 16 14:02:11 -04 2021

# Failed test 'check that the warning is logged'
# at t/019_replslot_limit.pl line 187.

# Failed test 'check that the slot became inactive and the state "lost" persists'
# at t/019_replslot_limit.pl line 198.
# got: 'rep1|t|t|lost|'
# expected: 'rep1|f|t|lost|'

# Failed test 'check that segments have been removed'
# at t/019_replslot_limit.pl line 213.
# got: '000000010000000000000014'
# expected: '00000001000000000000001C'
# Looks like you failed 3 tests of 19.
make[2]: *** [Makefile:23: check] Error 1

The buildfarm has remained green so far, but clearly this is something
we need to fix. Maybe it's as simple as adding the loop we use below,
starting at line 219.

--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Geoghegan 2021-07-16 23:40:05 Re: IRe: BUG #16792: silent corruption of GIN index resulting in SELECTs returning non-matching rows
Previous Message Jacob Champion 2021-07-16 18:02:18 Re: pg_upgrade test for binary compatibility of core data types