Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: jeff(dot)janes(at)gmail(dot)com, mk(at)071(dot)ovh, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size
Date: 2021-07-15 21:33:20
Message-ID: 202107152133.dekh4keh4r44@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2021-Jul-15, Alvaro Herrera wrote:

> Actually, looking again, isn't this supposed to happen in KeepLogSeg()?
> We have a block that caps to max_slot_wal_keep_size_mb there ... why did
> that not work?

I find that this smaller patch is sufficient to make the added test case
work. However, I'm not sure I understand *why* ...

--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/

Attachment Content-Type Size
v5-0001-Advance-old-segment-horizon-properly-after-slot-i.patch text/x-diff 4.3 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2021-07-15 22:04:41 BUG #17111: Database created, cannot be created, but reported as inexist
Previous Message Alvaro Herrera 2021-07-15 20:49:10 Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size