| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Don't block HOT update by BRIN index |
| Date: | 2021-07-12 20:55:31 |
| Message-ID: | 202107122055.6bzswduhiiyo@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jul-12, Tomas Vondra wrote:
> Well, one of us is confused and it might be me ;-)
:-)
> The point is that BRIN is the only index type with amhotblocking=false,
> so it would return NULL (and thus it does not block HOT). All other
> indexes AMs have amblocking=true and so should return rd_indexattr (I
> forgot to change that in the code chunk).
But RelationGetIndexAttrBitmap is called for the table that contains the
index (and probably contains some other indexes too), not for one
specific index. So the bitmap is about the columns involved in *all*
indexes of the table ...
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"El destino baraja y nosotros jugamos" (A. Schopenhauer)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2021-07-12 20:57:15 | Re: Fix comments of heap_prune_chain() |
| Previous Message | Tomas Vondra | 2021-07-12 20:54:54 | Re: [PATCH] Don't block HOT update by BRIN index |