| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> |
| Subject: | Re: Outdated replication protocol error? |
| Date: | 2021-07-09 01:12:52 |
| Message-ID: | 20210709011252.tqxim43c25vdz3vo@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2021-06-17 18:13:57 -0700, Jeff Davis wrote:
> On Wed, 2021-06-16 at 16:17 -0700, Andres Freund wrote:
> > I think we should explicitly compute the current timeline before
> > using
> > ThisTimelineID. E.g. in StartReplication() call a new version of
> > GetFlushRecPtr() that also returns the current timeline id.
>
> I think all we need to do is follow the pattern in IdentifySystem() by
> calling:
>
> am_cascading_walsender = RecoveryInProgress();
>
> first.
Yea, that sounds reasonable.
I'm not a fan of hiding the timeline determination inside
RecoveryInProgress(), particularly not when communicated via global
variable. But that's not the fault of this patch.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Quan Zongliang | 2021-07-09 01:26:37 | Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers. |
| Previous Message | Fujii Masao | 2021-07-09 00:55:17 | Re: Inaccurate error message when set fdw batch_size to 0 |