Re: Some incorrect logs in TAP tests of pgbench

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Some incorrect logs in TAP tests of pgbench
Date: 2021-06-25 15:55:13
Message-ID: 202106251555.oiswb72kivrn@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Jun-25, Michael Paquier wrote:

> I am a bit dubious that this information is useful when it comes to
> debugging because we have the name of the tests close by, so I would
> just remove those extra logs. If people prefer keeping this
> information around, we could fix the format with something like the
> attached, for example.

I agree it's not useful -- command_checks_all logs each element of those
arrays already, when doing its like(). So ISTM we can do away with them.

--
Álvaro Herrera 39°49'30"S 73°17'W
"Most hackers will be perfectly comfortable conceptualizing users as entropy
sources, so let's move on." (Nathaniel Smith)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Anton Voloshin 2021-06-25 17:47:50 [patch] remove strver's leftover from error message in Solution.pm
Previous Message Peter Geoghegan 2021-06-25 15:43:55 Re: Using indexUnchanged with nbtree