Re: Use singular number when appropriate

From: David Fetter <david(at)fetter(dot)org>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use singular number when appropriate
Date: 2021-06-15 15:30:57
Message-ID: 20210615153057.GD3983@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 15, 2021 at 09:37:11AM +0200, Laurenz Albe wrote:
> On Tue, 2021-06-15 at 04:59 +0000, David Fetter wrote:
> > I thought about using the dual, but wasn't sure how many languages
> > support it.
>
> I think none of the languages for which we cater uses the dual. But
> I guess you were joking, since the tests are not translated ...

I was.

> > if (fail_count == 0 && fail_ignore_count == 0)
> > snprintf(buf, sizeof(buf),
> > - _(" All %d tests passed. "),
> > - success_count);
> > + _(" %s %d test%s passed. "),
> > + success_count == 1 ? "The" : "All",
> > + success_count,
> > + success_count == 1 ? "" : "s");
>
> ... and that wouldn't be translatable.

Thanks, will rearrange.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-06-15 15:33:05 Re: [PATCH] expand the units that pg_size_pretty supports on output
Previous Message Dmitry Dolgov 2021-06-15 15:18:50 Re: pg_stat_statements and "IN" conditions