| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: Failure in subscription test 004_sync.pl |
| Date: | 2021-06-14 14:40:31 |
| Message-ID: | 202106141440.nfh7jixuhein@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jun-14, Amit Kapila wrote:
> On Mon, Jun 14, 2021 at 10:41 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > The condition should be the opposite; we should raise the error when
> > 'nowait' is true. I think this is the cause of the test failure. Even
> > if DROP SUBSCRIPTION tries to drop the slot with the WAIT option, we
> > don't wait but raise the error.
>
> Yes, this should fix the recent buildfarm failures. Alvaro, would you
> like to take care of this?
Ugh, thanks for CCing me. Yes, I'll get this fixed ASAP.
--
Álvaro Herrera Valdivia, Chile
"Saca el libro que tu religión considere como el indicado para encontrar la
oración que traiga paz a tu alma. Luego rebootea el computador
y ve si funciona" (Carlos Duclós)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-06-14 14:51:44 | Re: Replication protocol doc fix |
| Previous Message | Don Seiler | 2021-06-14 14:16:39 | Re: Estimating HugePages Requirements? |