Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)
Date: 2021-06-12 01:12:55
Message-ID: 20210612011255.GB8278@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 11, 2021 at 08:56:19PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > OK, I came up with the attached patch. This is one of the few cases
> > where the incompatibility is not clearly related to the feature, so I
> > left the existing item alone and just created a new one with the same
> > commit message in the incompatibilities section.
>
> I think phrasing this as though user-defined aggregates are the only
> pain point is incorrect. For example, a custom operator based on
> array_cat would have issues too.
>
> I suggest a treatment more like
>
> Some built-in array-related functions changed signature (Tom Lane)
>
> Certain functions were redefined to take anycompatiblearray instead
> of anyarray. While this does not affect ordinary calls, it does
> affect code that directly names these functions along with their
> argument types; for example, custom aggregates and operators based
> on these functions. The affected functions are [ blah, blah ]

OK, I used some of your ideas and tried for something more general;
patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

If only the physical world exists, free will is an illusion.

Attachment Content-Type Size
agg.diff text/x-diff 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-06-12 01:17:46 Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)
Previous Message Tom Lane 2021-06-12 00:56:19 Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)