| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Muhammad Usama <m(dot)usama(at)gmail(dot)com> |
| Subject: | Re: A new function to wait for the backend exit after termination |
| Date: | 2021-06-05 01:32:36 |
| Message-ID: | 20210605013236.GA208701@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 01, 2021 at 01:25:24PM +0530, Bharath Rupireddy wrote:
> On Tue, Jun 1, 2021 at 9:19 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > Given that limitation, is pg_wait_for_backend_termination() useful enough? If
> > waiting for procarray departure is enough, should pg_wait_until_termination()
> > check BackendPidGetProc(pid) instead of kill(0, pid), so it can return
> > earlier?
>
> We can just remove BackendPidGetProc(pid) in
> pg_wait_for_backend_termination. With this change, we can get rid of
> the wait_pid() from regress.c. But, my concern is that the
> pg_wait_for_backend_termination() can also check non-postgres server
> process pid. Is this okay?
It may or may not be okay. I would not feel good about it.
> In that case, this function becomes a
> generic(OS level function) rather than a postgres server specific
> function. I'm not sure if all agree to that. Thoughts?
My preference is to remove pg_wait_for_backend_termination(). The use case
that prompted this thread used pg_terminate_backend(pid, 180000); it doesn't
need pg_wait_for_backend_termination().
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-06-05 01:41:31 | Re: installcheck failure in indirect_toast with default_toast_compression = lz4 |
| Previous Message | Jeff Davis | 2021-06-05 00:41:24 | Re: Make unlogged table resets detectable |