Re: Move pg_attribute.attcompression to earlier in struct for reduced size?

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date: 2021-05-27 22:10:19
Message-ID: 20210527221019.GG2082@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 25, 2021 at 08:33:47PM -0500, Justin Pryzby wrote:
> On Sun, May 23, 2021 at 12:25:10PM -0400, Tom Lane wrote:
> > However, the more I looked at that code the less I liked it.
> > I think the way that compression selection is handled for indexes,
> > ie consult default_toast_compression on-the-fly, is *far* saner
> > than what is currently implemented for tables. So I think we
> > should redefine attcompression as "ID of a compression method
> > to use, or \0 to select the prevailing default. Ignored if
> > attstorage does not permit the use of compression".
>
> +1
>
> It reminds me of reltablespace, which is stored as 0 to mean the database's
> default tablespace.

I was surprised to realize that I made this same suggestion last month...
https://www.postgresql.org/message-id/20210320074420.GR11765@telsasoft.com
|..unless we changed attcompression='\0' to mean (for varlena) "the default
|compression". Rather than "resolving" to the default compression at the time
|the table is created, columns without an explicit compression set would "defer"
|to the GUC (of course, that only affects newly-inserted data).

The original reason for that suggestion Michael handled differently in
63db0ac3f9e6bae313da67f640c95c0045b7f0ee

--
Justin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-05-27 22:42:58 Re: storing an explicit nonce
Previous Message Stephen Frost 2021-05-27 21:09:42 Re: storing an explicit nonce