Re: automatic analyze: readahead - add "IO read time" log message

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: automatic analyze: readahead - add "IO read time" log message
Date: 2021-05-26 00:49:35
Message-ID: 20210526004935.GF3676@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This patch adds hits/misses/dirtied, but explain says hit/read/dirtied/written.

Should it say "read" instead of "misses" ?

src/backend/access/heap/vacuumlazy.c: _("buffer usage: %lld hits, %lld misses, %lld dirtied\n"),

src/backend/commands/explain.c- appendStringInfo(es->str, " hit=%lld",
src/backend/commands/explain.c- (long long) usage->shared_blks_hit);
src/backend/commands/explain.c- if (usage->shared_blks_read > 0)
src/backend/commands/explain.c- appendStringInfo(es->str, " read=%lld",
src/backend/commands/explain.c- (long long) usage->shared_blks_read);
src/backend/commands/explain.c- if (usage->shared_blks_dirtied > 0)
src/backend/commands/explain.c: appendStringInfo(es->str, " dirtied=%lld",
src/backend/commands/explain.c- (long long) usage->shared_blks_dirtied);
src/backend/commands/explain.c- if (usage->shared_blks_written > 0)
src/backend/commands/explain.c- appendStringInfo(es->str, " written=%lld",
src/backend/commands/explain.c- (long long) usage->shared_blks_written);
src/backend/commands/explain.c- if (has_local || has_temp)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2021-05-26 00:57:31 Re: automatic analyze: readahead - add "IO read time" log message
Previous Message Stephen Frost 2021-05-26 00:49:11 Re: Add ZSON extension to /contrib/