Re: libpq_pipeline in tmp_install

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: libpq_pipeline in tmp_install
Date: 2021-05-19 15:48:47
Message-ID: 20210519154847.GA18436@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-May-19, Tom Lane wrote:

> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> > On 10.05.21 20:26, Peter Eisentraut wrote:
> >> The reason this is there is that the test suite uses PGXS to build the
> >> test program, and so things get installed automatically.  I suggest that
> >> we should either write out the build system by hand to avoid this, or
> >> maybe extend PGXS to support building programs but not installing them.
>
> > Here is a patch that implements the second solution, which turned out to
> > be very easy.

Great, thank you.

> +1, except that you should add documentation for NO_INSTALL to the
> list of definable symbols at the head of pgxs.mk, and to the list
> in extend.sgml (compare that for NO_INSTALLCHECK).

I propose this.

--
Álvaro Herrera Valdivia, Chile

Attachment Content-Type Size
noinstall-doc.patch text/x-diff 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-05-19 16:01:24 Re: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?
Previous Message Fabien COELHO 2021-05-19 15:25:10 Re: pgbench test failing on 14beta1 on Debian/i386