Re: Typo in README.barrier

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: dgrowleyml(at)gmail(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Typo in README.barrier
Date: 2021-05-17 00:33:27
Message-ID: 20210517.093327.114113254723373563.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Thanks for working on that. I had a look and wondered if it might be
> better to go into slightly less details about the exact atomic
> function to use. The wording there might lead you to believe you can
> just call the atomic function on the non-atomic variable.
>
> It might be best just to leave the details about how exactly to use
> atomics by just referencing port/atomics.h.
>
> Maybe something like the attached?

Thanks. Agreed and your patch looks good to me.

> I'm also a bit on the fence if this should be backpatched or not. The
> reasons though maybe not is that it seems unlikely maybe people would
> not be working in master if they're developing something new. On the
> other side of the argument, 0ccebe779, which adjusts another README
> was backpatched. I'm leaning towards backpatching.

Me too. Let's backpatch.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tsunakawa.takay@fujitsu.com 2021-05-17 00:43:07 RE: FDW and connections
Previous Message Justin Pryzby 2021-05-17 00:29:36 Re: terminate called after throwing an instance of 'std::bad_alloc'