| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: compute_query_id and pg_stat_statements |
| Date: | 2021-05-13 15:35:13 |
| Message-ID: | 20210513153513.dn57q6red5nw55kj@nol |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 13, 2021 at 10:41:43AM -0400, Bruce Momjian wrote:
>
> Well, now that we have clear warnings when it is misconfigured,
> especially when querying the pg_stat_statements view, are these
> complaints still valid?
I'm personally fine with it, and I can send a new version with just the
warning when calling pg_stat_statements() or one of the view(s). Or was there
other warnings that you were referring too?
> I am personally not comfortable committing a patch to add an auto option
> the way it is implemented, so another committer will need to take
> ownership of this, or the entire feature can be removed.
That's fair. Just to be clear, I'm assuming that you also don't like
Horigushi-san approach either?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-05-13 15:38:48 | Re: compute_query_id and pg_stat_statements |
| Previous Message | Maciek Sakrejda | 2021-05-13 15:32:50 | Re: compute_query_id and pg_stat_statements |