Re: compute_query_id and pg_stat_statements

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: magnus(at)hagander(dot)net, masao(dot)fujii(at)oss(dot)nttdata(dot)com, michael(at)paquier(dot)xyz, andres(at)anarazel(dot)de, tgl(at)sss(dot)pgh(dot)pa(dot)us, alvherre(at)alvh(dot)no-ip(dot)org, sfrost(at)snowman(dot)net, bruce(at)momjian(dot)us, myon(at)debian(dot)org, peter(dot)eisentraut(at)enterprisedb(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: compute_query_id and pg_stat_statements
Date: 2021-05-13 01:42:28
Message-ID: 20210513014228.h5n3isle2q46hze5@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 13, 2021 at 09:59:43AM +0900, Kyotaro Horiguchi wrote:
>
> The query_id of its own is provided because pg_stat_statements did not
> expose query_id. And it has been preserved only for the case the
> plugin is used without pg_stat_statements activated. Now that the
> in-core query_id is available, the last reason for the special
> provider has gone.

Ah I see, indeed that makes sense. However I'm assuming that pg_store_plans
also requires *a* queryid, not specifically what used to be pg_stat_statements'
one right, so it could also fallback on an alternative implementation if users
configured one? Even if that's not the case, the core query_id can still be
calculated if needed as the function is now exported.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-05-13 01:51:52 Re: compute_query_id and pg_stat_statements
Previous Message Pengchengliu 2021-05-13 01:25:05 RE: Parallel scan with SubTransGetTopmostTransaction assert coredump