From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Amul Sul <sulamul(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Remove redundant variable from transformCreateStmt |
Date: | 2021-04-29 18:39:42 |
Message-ID: | 20210429183942.GA10172@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021-Apr-29, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > I'd do it like this. Note I removed an if/else block in addition to
> > your changes.
>
> > I couldn't convince myself that this is worth pushing though; either we
> > push it to all branches (which seems unwarranted) or we create
> > back-patching hazards.
>
> Yeah ... an advantage of the if/else coding is that it'd likely be
> simple to extend to cover additional statement types, should we ever
> wish to do that. The rendering you have here is nice and compact,
> but it would not scale up well.
That makes sense. But that part is not in Amul's patch -- he was only
on about removing the is_foreign_table Boolean. If I remove the if/else
block change, does the rest of the patch looks something we'd want to
have? I kinda agree that the redundant variable is "ugly". Is it worth
removing? My hunch is no.
--
Álvaro Herrera 39°49'30"S 73°17'W
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2021-04-29 19:05:31 | Re: Patch to allow pg_filedump to support reading of pg_filenode.map |
Previous Message | Richard Yen | 2021-04-29 18:22:05 | Re: Patch to allow pg_filedump to support reading of pg_filenode.map |