| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Vaibhav Dalvi <vaibhav(dot)dalvi(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, Amul Sul <sulamul(at)gmail(dot)com> |
| Subject: | Re: Remove post-increment in function quote_identifier of pg_upgrade |
| Date: | 2021-04-29 15:16:53 |
| Message-ID: | 20210429151653.GA25016@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Apr-29, Tom Lane wrote:
> (On the other hand, if it were written the other way already, I'd also
> argue to leave it like that. Basically, this sort of change is just not
> worth troubling over. It doesn't improve things meaningfully and it
> creates back-patching hazards.)
This argument applies equally well to the patch at
http://postgr.es/m/CAAJ_b94M_1YoybQpNjmD+ZFZkUT2OpoP5xnFiWM+X=xh-nX23Q@mail.gmail.com
so if we reject this one, we should reject that one too.
CC'ed patch author.
--
Álvaro Herrera Valdivia, Chile
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-04-29 15:20:06 | Re: Remove redundant variable from transformCreateStmt |
| Previous Message | Stephen Frost | 2021-04-29 15:06:18 | Re: pg_hba.conf.sample wording improvement |