| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |
| Date: | 2021-04-26 19:44:46 |
| Message-ID: | 20210426194446.GA8513@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Apr-26, Alvaro Herrera wrote:
> > Please allow me to study the patch a bit more closely and get back tomorrow.
>
> Sure, thanks!
Here's a more polished version.
After trying the version with the elog(ERROR) when two detached
partitions are present, I decided against it; it is unhelpful because
it doesn't let you build partition descriptors for anything. So I made
it an elog(WARNING) (not an ereport, note), and keep the most recent
pg_inherits.xmin value. This is not great, but it lets you out of the
situation by finalizing one of the detaches.
The other check (at ALTER TABLE .. DETACH time) is an ereport(ERROR) and
should make the first one unreachable.
--
Álvaro Herrera 39°49'30"S 73°17'W
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Allow-a-partdesc-with-omitted-partitions-to-be-cache.patch | text/x-diff | 21.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-04-26 19:58:46 | Re: Use simplehash.h instead of dynahash in SMgr |
| Previous Message | Yura Sokolov | 2021-04-26 19:44:13 | Re: Use simplehash.h instead of dynahash in SMgr |