| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Cc: | tanghy(dot)fnst(at)fujitsu(dot)com, smithpb2250(at)gmail(dot)com, peter(dot)eisentraut(at)enterprisedb(dot)com, david(dot)zhang(at)highgo(dot)ca, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Support tab completion for upper character inputs in psql |
| Date: | 2021-04-23 03:34:07 |
| Message-ID: | 20210423.123407.440405986257584017.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 22 Apr 2021 23:17:19 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
> Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
> > All usages of pg_string_tolower don't need a copy.
> > So don't we change the function to in-place converter?
>
> Doesn't seem like a good idea, because that locks us into an assumption
> that the downcasing conversion doesn't change the string's physical
> length. There are a lot of counterexamples to that :-(. I'm not sure
Mmm. I didn't know of that.
> that we actually implement such cases correctly today, but let's not
> build APIs that prevent it from being fixed.
Agreed. Thanks for the knowledge.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shiy.fnst@fujitsu.com | 2021-04-23 03:41:14 | RE: Truncate in synchronous logical replication failed |
| Previous Message | Kyotaro Horiguchi | 2021-04-23 03:25:36 | Re: Support tab completion for upper character inputs in psql |