| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: INCLUDING COMPRESSION (sort enum fields) |
| Date: | 2021-04-22 23:51:23 |
| Message-ID: | 20210422235123.GH7256@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs pgsql-hackers |
(moved to -hackers)
https://www.postgresql.org/message-id/flat/54d30e66-dbd6-5485-aaf6-a291ed55919d%40oss.nttdata.com
On Thu, Apr 15, 2021 at 11:24:07PM +0900, Fujii Masao wrote:
> On 2021/04/15 11:54, Michael Paquier wrote:
> > May I ask at the same time why gram.y (TableLikeOption) and
> > parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
> > option in alphabetical order with the rest? Ordering them makes
> > easier a review of them.
>
> I'm not sure why. But +1 to make them in alphabetical order.
> Patch attached.
+1 to your patch
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| including_compression_order.patch | text/x-diff | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2021-04-23 07:40:04 | Re: Rounding strategy |
| Previous Message | Tom Lane | 2021-04-22 17:50:20 | Re: Rounding strategy |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiro Ikeda | 2021-04-23 00:26:17 | Re: wal stats questions |
| Previous Message | Mark Dilger | 2021-04-22 23:28:12 | Re: pg_amcheck contrib application |