Re: TRUNCATE on foreign table

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kohei KaiGai <kaigai(at)heterodb(dot)com>, Kazutaka Onishi <onishi(at)heterodb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Subject: Re: TRUNCATE on foreign table
Date: 2021-04-22 17:34:37
Message-ID: 20210422173437.GD7256@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 22, 2021 at 07:41:06AM -0700, Zhihong Yu wrote:
> > > > + Note that <literal>ONLY</literal> option specified in
> > >
> > > add "the" to say: "the ONLY"
> >
> > +1.
>
> Since 'the only option' is legitimate English phrase, I think the following
> would be clearer:
>
> Note that the option <literal>ONLY</literal> ...

I think the ONLY option is better, more clear, and more consistent with the
rest of the documentation.

There are only ~5 places where we say "the option >OPTION<":
| git grep 'the option <' doc/src/sgml/

And at least 150 places where we say "The >OPTION< option" (I'm sure there are
some more which are split across lines).
| git grep -E 'the <([^>]*)>[^<]*</\1> option' doc/src/sgml/ |wc -l

--
Justin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-04-22 17:43:46 Re: pgsql: autovacuum: handle analyze for partitioned tables
Previous Message Alvaro Herrera 2021-04-22 17:32:48 Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids