| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Hannu Krosing <hannuk(at)google(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Atsushi Torikoshi <atorik(at)gmail(dot)com>, Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Evgeny Efimkin <efimkin(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Date: | 2021-04-08 13:31:27 |
| Message-ID: | 20210408133127.pex4rwdomsjibcqp@nol |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 08, 2021 at 08:27:20PM +0800, Julien Rouhaud wrote:
> On Thu, Apr 08, 2021 at 05:46:07PM +0530, Amit Kapila wrote:
> >
> > @@ -1421,8 +1421,9 @@ ParallelQueryMain(dsm_segment *seg, shm_toc *toc)
> > /* Setting debug_query_string for individual workers */
> > debug_query_string = queryDesc->sourceText;
> >
> > - /* Report workers' query for monitoring purposes */
> > + /* Report workers' query and queryId for monitoring purposes */
> > pgstat_report_activity(STATE_RUNNING, debug_query_string);
> > + pgstat_report_queryid(queryDesc->plannedstmt->queryId, false);
> >
> >
> > Below lines down in ParallelQueryMain, we call ExecutorStart which
> > will report queryid, so do we need it here?
>
> Correct, it's not actually needed. The overhead should be negligible but let's
> get rid of it. Updated fix patchset attached.
Sorry I messed up the last commit, v4 is ok.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Ignore-parallel-workers-in-pg_stat_statements.patch | text/x-diff | 1.5 KB |
| v4-0002-Fix-thinko-in-pg_stat_get_activity-when-retrievin.patch | text/x-diff | 812 bytes |
| v4-0003-Remove-unnecessary-call-to-pgstat_report_queryid.patch | text/x-diff | 933 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2021-04-08 13:49:20 | Re: 2019-03 CF now in progress |
| Previous Message | Magnus Hagander | 2021-04-08 13:18:09 | Re: pg_stat_statements oddity with track = all |