| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Move pg_stat_statements query jumbling to core. |
| Date: | 2021-04-08 06:49:19 |
| Message-ID: | 20210408064919.bxqnzpi2ctt3rfzg@nol |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Apr 08, 2021 at 12:08:02PM +0530, Amit Kapila wrote:
> On Thu, Apr 8, 2021 at 11:40 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> >
> > That was indeed the problem. I think the best is to entirely ignore parallel
> > workers in pg_stat_statements,
> >
>
> I haven't studied this patch but I have a question here. We normally
> do accumulate the stats from parallel workers for the purpose of
> Explain Analyze, so won't ignoring them in pg_stat_statements a bit
> inconsistent but if that is the case even before this patch then that
> might be fine?
I think that this patch shouldn't change pg_stat_statements previous behavior,
and that the previous behavior was correct.
It doesn't change the way we get instrumentation data from parallel workers,
just avoid to have parallel workers call pgss_store and report multiple time
the same activity. The only difference is that now pg_stat_statements won't
setup instrumentation flags, but those should be inherited in parallel worker
from the main process right?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2021-04-08 08:30:51 | pgsql: Track identical top vs nested queries independently in pg_stat_s |
| Previous Message | Amit Kapila | 2021-04-08 06:38:02 | Re: pgsql: Move pg_stat_statements query jumbling to core. |