| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: multi-install PostgresNode fails with older postgres versions |
| Date: | 2021-04-07 19:09:24 |
| Message-ID: | 20210407190924.GA13559@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Apr-07, Andrew Dunstan wrote:
> Aren't you likely to end up duplicating substantial amounts of code,
> though?
No — did you look at his code? Each version is child of the one just
above, so you only need to override things where behavior changes from
one version to the next.
> I'm certainly not at the stage where I think the version-aware
> code is creating too much clutter. The "forest of conditionals" seems
> more like a small thicket.
After comparing both approaches, I think ioguix's is superior in
cleanliness.
--
Álvaro Herrera 39°49'30"S 73°17'W
<Schwern> It does it in a really, really complicated way
<crab> why does it need to be complicated?
<Schwern> Because it's MakeMaker.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-04-07 19:10:34 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Previous Message | Andrew Dunstan | 2021-04-07 18:53:25 | Re: buildfarm instance bichir stuck |