| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | tsunakawa(dot)takay(at)fujitsu(dot)com, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Amit Langote <amitlangote09(at)gmail(dot)com>, tanghy(dot)fnst(at)fujitsu(dot)com, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, houzj(dot)fnst(at)fujitsu(dot)com |
| Subject: | Re: [POC] Fast COPY FROM command for the table with foreign partitions |
| Date: | 2021-03-23 03:23:22 |
| Message-ID: | 20210323032322.GW4203@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 22, 2021 at 08:18:56PM -0700, Zhihong Yu wrote:
> with data_dest_cb callback. It is used for send text representation of a
> tuple to a custom destination.
>
> send text -> sending text
I would say "It is used to send the text representation ..."
> struct PgFdwModifyState *aux_fmstate; /* foreign-insert state, if
> * created */
> + CopyToState cstate; /* foreign COPY state, if used */
>
> Since foreign COPY is optional, should cstate be a pointer ? That would be
> in line with aux_fmstate.
It's actually a pointer:
src/include/commands/copy.h:typedef struct CopyToStateData *CopyToState;
There's many data structures like this, where a structure is typedefed with a
"Data" suffix and the pointer is typedefed without the "Data"
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-03-23 03:28:15 | Re: New IndexAM API controlling index vacuum strategies |
| Previous Message | Greg Stark | 2021-03-23 03:20:46 | Re: shared memory stats: high level design decisions: consistency, dropping |