| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [HACKERS] Custom compression methods |
| Date: | 2021-03-22 14:44:47 |
| Message-ID: | 20210322144447.GJ4203@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 22, 2021 at 10:41:33AM -0400, Robert Haas wrote:
> On Sun, Mar 21, 2021 at 7:55 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > Rebased again.
>
> Thanks, Justin. I committed 0003 and 0004 together as
> 226e2be3876d0bda3dc33d16dfa0bed246b7b74f. I also committed 0001 and
> 0002 together as 24f0e395ac5892cd12e8914646fe921fac5ba23d, but with
> some revisions, because your text was not clear that this is setting
> the default for new tables, not new values; it also implied that this
> only affects out-of-line compression, which is not true. In lieu of
> trying to explain how TOAST works here, I added a link. It looks,
> though, like that documentation also needs to be patched for this
> change. I'll look into that, and your remaining patches, next.
Thanks. I just realized that if you also push the GUC change, then the docs
should change from <string> to <enum>
doc/src/sgml/config.sgml: <term><varname>default_toast_compression</varname> (<type>string</type>)
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2021-03-22 14:57:58 | Re: Minimal logical decoding on standbys |
| Previous Message | Tom Lane | 2021-03-22 14:41:48 | Re: [HACKERS] Custom compression methods (mac+lz4.h) |