Re: psql tab completion for \h with IMPORT FOREIGN SCHEMA

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: psql tab completion for \h with IMPORT FOREIGN SCHEMA
Date: 2021-03-18 07:13:17
Message-ID: 20210318071317.uh3kdzg52jyvqbdc@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 18, 2021 at 03:58:46PM +0900, Michael Paquier wrote:
>
> Well, as $subject tells, I just found confusing that \h does not
> complete the so-said command, the only one using IMPORT as keyword,
> so I'd like to do the following:
> --- a/src/bin/psql/tab-complete.c
> +++ b/src/bin/psql/tab-complete.c
> @@ -1493,7 +1493,7 @@ psql_completion(const char *text, int start, int end)
> "ABORT", "ALTER", "ANALYZE", "BEGIN", "CALL", "CHECKPOINT", "CLOSE", "CLUSTER",
> "COMMENT", "COMMIT", "COPY", "CREATE", "DEALLOCATE", "DECLARE",
> "DELETE FROM", "DISCARD", "DO", "DROP", "END", "EXECUTE", "EXPLAIN",
> - "FETCH", "GRANT", "IMPORT", "INSERT", "LISTEN", "LOAD", "LOCK",
> + "FETCH", "GRANT", "IMPORT FOREIGN SCHEMA", "INSERT", "LISTEN", "LOAD", "LOCK",
> "MOVE", "NOTIFY", "PREPARE",
> "REASSIGN", "REFRESH MATERIALIZED VIEW", "REINDEX", "RELEASE",
> "RESET", "REVOKE", "ROLLBACK",

Looks sensible to me.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-03-18 07:16:54 Re: A new function to wait for the backend exit after termination
Previous Message Michael Paquier 2021-03-18 06:58:46 psql tab completion for \h with IMPORT FOREIGN SCHEMA